fix(ci): quote the real version in the upgrade snippet - #5
Merged
Conversation
The release notes derive the version from --to, which is HEAD when notes are generated before the tag exists, so the upgrade command rendered: helm upgrade ... --version HEAD Pass the release version explicitly. The generator still falls back to --to, which is correct when --to is a tag. Verified in kube-workspaces/deploy, whose v0.2.2 notes hit this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-notes generator derives the version from
--to, which isHEADwhennotes are generated before the tag exists. So the upgrade command in published
notes rendered:
Pass the release version explicitly. The generator still falls back to
--to,which is correct when
--tois a tag.Caught on
kube-workspaces/deployv0.2.2, the first fully-automated release. Itsnotes have been corrected by hand; from the next release this is unattended.